-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tokens in <|>
relevant to syntax match
#1744
Conversation
<|>
relevant to syntax match
4f05083
to
6cab36f
Compare
I suppose
|
The simplest solution would be to define
and then use |
I think for discharger, we can just remove the |
I'm still unsure what to do about something like
In built-in syntax this would be
but then we would have to write
except maybe with a better name. |
The one-size-fits-all solution for when ParserDescr is not expressive enough is to make a parser alias. I think this also depends on (y)our long-term plans: do we want to get rid of We've discussed the |
I do!
Ah, you're right. Unless someone can think of a better name, I'd probably go with that. |
@@ -337,14 +337,15 @@ macro_rules | |||
|
|||
section | |||
open Lean.Parser.Tactic | |||
syntax cdotTk := patternIgnore("·" <|> ".") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only case where I had to introduce a new syntax abbrev, since a token quotation inside patternIgnore
obviously can't work anymore. And yes, I went with a less "cute" name than nomatch
after all.
Implements #1275 (comment)
Fixes #1275